Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates and correction for v0.3 #84

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Updates and correction for v0.3 #84

merged 7 commits into from
Aug 3, 2023

Conversation

altairgomes
Copy link
Collaborator

@altairgomes altairgomes commented Jul 8, 2023 •
edited
Loading

This PR add bug fixes to v0.3

  • Fixes Error trying to define Body using model.obj files to fit chords #83, a bug that that did not properly read OBj files in some cases.
  • Removed numpy.float as it is deprecated in numpy.
  • Removed cache from SBDB as it may not get new data from the webserver.
  • Fixes Limb not working with shapely 2.0 #81, a problem with shapely version update to v2.0.
  • Fixes orientation parameters for some satellites and asteroids from Archinal where the longitude was counted in the wrong direction. We also included the new SPKID for the asteroids so it should not be missed.
  • Fixed problem in occultation maps where the error bars were not plotted outside Earth.

New feature:

  • A small new feature was implemented. Now, it is possible to obtain the final astrometric position of the body considering the relative light deflection between the body and the star caused by the Sun. At this moment, this correction is applied only on the method "new_astrometric_position" of the Occultation object. Also, only the gravitational deflection by the Sun is being considered. Deflection by the planets may be included in future versions.

@altairgomes altairgomes requested a review from Bmorgado19 July 8, 2023 01:46
@altairgomes altairgomes added enhancement New feature or request map body labels Jul 8, 2023
@altairgomes altairgomes added this to the 0.3.1 milestone Jul 8, 2023
Bmorgado19
Bmorgado19 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@Bmorgado19 Bmorgado19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These modifications were approved. One thing that is important to notice is that the code does not work using cartopy==0.19.0 as stated in the documentation. This should be corrected in the README.md and the documentation.

@Bmorgado19 Bmorgado19 merged commit 92399e1 into riogroup:develop Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bmorgado19 Bmorgado19 Bmorgado19 approved these changes

Assignees
No one assigned
Labels
body enhancement New feature or request map
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@altairgomes @Bmorgado19